josh-mckenzie commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r687149857
##########
File path: src/java/org/apache/cassandra/transport/PreV5Handlers.java
##########
@@ -63,19 +64,21 @@
* Note: should only be accessed while on the netty event loop.
*/
private long channelPayloadBytesInFlight;
- private boolean paused;
+
+ /** The cause of the current connection pause, or {@link
Overload#NONE} if it is unpaused. */
+ private Overload pauseTrigger = Overload.NONE;
Review comment:
Ah. So usage wise, a `pausedDueToByteOverload` or something would be the
"only used in one place" context appropriate method, but at that point we're
well past diminishing returns into just cruft territory. Fine leaving this
as-is. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
