maedhroz commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r687057118
##########
File path: src/java/org/apache/cassandra/transport/PreV5Handlers.java
##########
@@ -123,48 +129,113 @@ private void
releaseItem(Flusher.FlushItem<Message.Response> item)
* purpose since it does not have the message envelope associated with
the exception.
* <p>
* Note: this method should execute on the netty event loop.
+ *
+ * @return the type of {@link Overload} triggered
*/
- private boolean shouldHandleRequest(ChannelHandlerContext ctx,
Message.Request request)
+ private Overload checkLimits(ChannelHandlerContext ctx,
Message.Request request)
Review comment:
Yeah, it's purpose was basically to communicate to the dispatcher
whether or not we need to issue a client warning without changing the existing
plumbing for enabling their collection. Agreed that a comment would clarify
this though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
