maedhroz commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r701180516
##########
File path: conf/cassandra.yaml
##########
@@ -1467,3 +1467,13 @@ enable_drop_compact_storage: false
# has exceeded this threshold, returning a read error to the user.
#client_large_read_warn_threshold_kb: 0
#client_large_read_abort_threshold_kb: 0
+
+# When client_track_warnings_enabled: true, this tracks the size of the local
read (as defined by
+# heap size), and will warn/abort based off these thresholds; 0 disables these
checks.
+#local_read_too_large_warning_threshold_kb: 0
+#local_read_too_large_abort_threshold_kb: 0
+
+# When client_track_warnings_enabled: true, this tracks the expected memory
size of the RowIndexEntry
+# and will warn/abort based off these thresholds; 0 disables these checks.
+#row_index_size_warning_threshold_kb: 0
+#row_index_size_abort_threshold_kb: 0
Review comment:
I'm 100% in favor of using nesting for new sets of properties when the
alternative would be ugly and redundant prefixing. (Honestly surprised I didn't
already suggest that here.) I think the conversation in CASSANDRA-15234 was
heading toward this as well, but it also has to deal with compatibility, a
concern we're more or less free of here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
