maedhroz commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r701288482
##########
File path: src/java/org/apache/cassandra/metrics/KeyspaceMetrics.java
##########
@@ -247,6 +256,15 @@ public KeyspaceMetrics(final Keyspace ks)
clientReadSizeWarnings = createKeyspaceMeter("ClientReadSizeWarnings");
clientReadSizeAborts = createKeyspaceMeter("ClientReadSizeAborts");
+ clientReadSize = createKeyspaceHistogram("ClientReadSize", false);
+
+ clientLocalReadSizeTooLargeWarnings =
createKeyspaceMeter("ClientLocalReadSizeTooLargeWarnings");
+ clientLocalReadSizeTooLargeAborts =
createKeyspaceMeter("ClientLocalReadSizeTooLargeAborts");
+ clientLocalReadSize = createKeyspaceHistogram("ClientLocalReadSize",
false);
Review comment:
Also a note to self: Check to see that the histograms are updated even
if warnings/aborts aren't enabled...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
