maedhroz commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r701287822
##########
File path: src/java/org/apache/cassandra/metrics/KeyspaceMetrics.java
##########
@@ -247,6 +256,15 @@ public KeyspaceMetrics(final Keyspace ks)
clientReadSizeWarnings = createKeyspaceMeter("ClientReadSizeWarnings");
clientReadSizeAborts = createKeyspaceMeter("ClientReadSizeAborts");
+ clientReadSize = createKeyspaceHistogram("ClientReadSize", false);
+
+ clientLocalReadSizeTooLargeWarnings =
createKeyspaceMeter("ClientLocalReadSizeTooLargeWarnings");
+ clientLocalReadSizeTooLargeAborts =
createKeyspaceMeter("ClientLocalReadSizeTooLargeAborts");
+ clientLocalReadSize = createKeyspaceHistogram("ClientLocalReadSize",
false);
Review comment:
The internals we can rename any time, but in terms of the externally
facing metric names, I'd consider something like
`CoordinatorReadSize`/`LocalReadSize` for the histograms. (The token "Client"
seems to be there mostly to indicate "things we send to the client", and these
histograms could exist independently.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
