maedhroz commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r701256261



##########
File path: src/java/org/apache/cassandra/utils/ObjectSizes.java
##########
@@ -32,7 +32,6 @@
 public class ObjectSizes
 {
     private static final MemoryMeter meter = new MemoryMeter()
-                                             .omitSharedBufferOverhead()

Review comment:
       Looking through the usages of `measureDeep()`, it doesn't seem like any 
of those cases involve wrapping existing BBs, so this configuration option was 
indeed not necessary, but it would be good to get confirmation of that...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to