dcapwell commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r702169292



##########
File path: src/java/org/apache/cassandra/utils/ObjectSizes.java
##########
@@ -125,7 +124,7 @@ public static long sizeOnHeapOf(ByteBuffer buffer)
         // if we're only referencing a sub-portion of the ByteBuffer, don't 
count the array overhead (assume it's slab
         // allocated, so amortized over all the allocations the overhead is 
negligible and better to undercount than over)

Review comment:
       yep




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to