[GitHub] [cassandra] dcapwell commented on a change in pull request #1180: CASSANDRA-16896: Add soft/hard limits to local reads to protect against reading too much data in a single query

Tue, 07 Sep 2021 15:22:58 -0700 


dcapwell commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r703892988



##########
File path: src/java/org/apache/cassandra/db/ReadCommand.java
##########
@@ -632,6 +654,84 @@ private void maybeDelayForTesting()
         }
     }
 
+    private UnfilteredPartitionIterator 
withQuerySizeTracking(UnfilteredPartitionIterator iterator)
+    {
+        if (!trackWarnings || 
SchemaConstants.isSystemKeyspace(metadata().keyspace)) // exclude internal 
keyspaces

Review comment:
       ![Screen Shot 2021-09-07 at 3 21 44 
PM](https://user-images.githubusercontent.com/1852601/132418010-14059f74-4a09-4f91-9191-9c66c1c8ef77.png)
   
   first round of testing makes it look like a bug; we don't loose any 
warnings, but add another one




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to