dcapwell commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r703932764



##########
File path: src/java/org/apache/cassandra/db/ReadCommand.java
##########
@@ -632,6 +654,84 @@ private void maybeDelayForTesting()
         }
     }
 
+    private UnfilteredPartitionIterator 
withQuerySizeTracking(UnfilteredPartitionIterator iterator)
+    {
+        if (!trackWarnings || 
SchemaConstants.isSystemKeyspace(metadata().keyspace)) // exclude internal 
keyspaces

Review comment:
       trying to read what's going on in `read-repair`, `short read 
protection`, and `replica filtering protection` to see what is the best place 
to dedup.  So far read-repair looks like you need to handle in 
`AbstractReadExecutor`, but need to read the other two closer to confirm... 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to