dcapwell commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r703930489
##########
File path: src/java/org/apache/cassandra/db/ReadCommand.java
##########
@@ -632,6 +654,84 @@ private void maybeDelayForTesting()
}
}
+ private UnfilteredPartitionIterator
withQuerySizeTracking(UnfilteredPartitionIterator iterator)
+ {
+ if (!trackWarnings ||
SchemaConstants.isSystemKeyspace(metadata().keyspace)) // exclude internal
keyspaces
Review comment:
here are the call paths I see which call awaitResponse on ReadCallback
(which adds the warnings)
```
org.apache.cassandra.service.reads.ReadCallback#awaitResults
org.apache.cassandra.service.reads.AbstractReadExecutor#awaitResponses
org.apache.cassandra.service.StorageProxy#fetchRows
org.apache.cassandra.service.StorageProxy#readRegular
org.apache.cassandra.service.StorageProxy#read
org.apache.cassandra.db.SinglePartitionReadCommand$Group#execute
org.apache.cassandra.cql3.statements.SelectStatement#execute
org.apache.cassandra.cql3.statements.SelectStatement#execute
org.apache.cassandra.cql3.statements.SelectStatement#execute
```
```
org.apache.cassandra.service.reads.ReadCallback#awaitResults
org.apache.cassandra.service.reads.repair.AbstractReadRepair#awaitReads
org.apache.cassandra.service.reads.AbstractReadExecutor#awaitReadRepair
org.apache.cassandra.service.StorageProxy#fetchRows
org.apache.cassandra.service.StorageProxy#readRegular
org.apache.cassandra.service.StorageProxy#read
org.apache.cassandra.db.SinglePartitionReadCommand$Group#execute
org.apache.cassandra.cql3.statements.SelectStatement#execute
org.apache.cassandra.cql3.statements.SelectStatement#execute
org.apache.cassandra.cql3.statements.SelectStatement#execute
```
Based off code inspection I also see short-read-protection would have the
same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
