dcapwell commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r706392248
##########
File path: src/java/org/apache/cassandra/transport/Dispatcher.java
##########
@@ -110,6 +114,7 @@ else if (backpressure == Overload.BYTES_IN_FLIGHT)
Message.logger.trace("Received: {}, v={}", request,
connection.getVersion());
connection.requests.inc();
Message.Response response = request.execute(qstate,
queryStartNanoTime);
+ CoordinatorTrackWarnings.done();
Review comment:
> Is done() not called if there is an exception thrown from execute()
ATM no, nor do we retry ClientWarn in those cases as thats handled 2 lines
below. If you look at
`org.apache.cassandra.transport.Message.Request#execute(org.apache.cassandra.service.QueryState,
long)` its marked `final` and does imply exceptions could go up (it does
try-finally; no catch). If I look at the caller of this dispatch logic it
actually handles the exception and clears ClientWarn; will do the same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
