belliottsmith commented on code in PR #7: URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1011915458
########## accord-core/src/main/java/accord/coordinate/CollectDeps.java: ########## @@ -0,0 +1,87 @@ +package accord.coordinate; + +import java.util.ArrayList; +import java.util.List; +import java.util.function.BiConsumer; + +import accord.coordinate.tracking.QuorumTracker; +import accord.local.Node; +import accord.local.Node.Id; +import accord.messages.Callback; +import accord.messages.GetDeps; +import accord.messages.GetDeps.GetDepsOk; +import accord.primitives.Deps; +import accord.primitives.Route; +import accord.primitives.Timestamp; +import accord.primitives.Txn; +import accord.primitives.TxnId; +import accord.topology.Topologies; + +class CollectDeps implements Callback<GetDepsOk> Review Comment: Much like `CheckOn`, I intended `Fetch` to be about obtaining a complete representation of the local state, rather than simply obtaining. Also, the act of collating deps is different than fetching state, as we need a quorum of responses. So `Collect` seemed more appropriate, though we could use Collate or Assemble or something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
