belliottsmith commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1012016796
##########
accord-core/src/main/java/accord/coordinate/Coordinate.java:
##########
@@ -203,9 +203,10 @@ public void onCallbackFailure(Id from, Throwable failure)
tryFailure(failure);
}
- // TODO (soon): do we need to preaccept in later epochs? the sync logic
should take care of it for us, since
- // either we haven't synced between a majority and the
earlier epochs are still involved for
+ // TODO (soon): I don't think we need to preaccept in later epochs? the
Sync logic should take care of it for us,
+ // since either we haven't synced between a majority and the
earlier epochs are still involved for
// later preaccepts, or they have been sync'd and the earlier
transactions are known to the later epochs
+ // (also, we aren't doing this on recovery, and everything
works...)
private synchronized void onEpochUpdate()
Review Comment:
I think currently this can be invoked by an arbitrary thread, but I agree we
should fix all callbacks to the same thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
