belliottsmith commented on code in PR #7: URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1011942198
########## accord-core/src/main/java/accord/coordinate/CheckShards.java: ########## @@ -0,0 +1,83 @@ +package accord.coordinate; + +import java.util.Set; + +import accord.local.Node; +import accord.local.Node.Id; +import accord.messages.CheckStatus; +import accord.messages.CheckStatus.CheckStatusOk; +import accord.messages.CheckStatus.CheckStatusReply; +import accord.messages.CheckStatus.IncludeInfo; +import accord.primitives.RoutingKeys; +import accord.primitives.TxnId; +import accord.topology.Topologies; + +/** + * A result of null indicates the transaction is globally persistent + * A result of CheckStatusOk indicates the maximum status found for the transaction, which may be used to assess progress + */ +public abstract class CheckShards extends QuorumReadCoordinator<CheckStatusReply> Review Comment: Yes, I think all of the other places perform (to attempt to perform) recovery, so simply not propagating the durability is fine IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
