belliottsmith commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1012015522
##########
accord-core/src/main/java/accord/coordinate/Coordinate.java:
##########
@@ -279,13 +280,16 @@ private void onPreAccepted()
// TODO: perhaps don't submit Accept immediately if we almost have
enough for fast-path,
// but by sending accept we rule out hybrid fast-path
permitHybridFastPath = executeAt.compareTo(txnId) == 0;
- node.withEpoch(executeAt.epoch, () -> Propose.propose(node,
tracker.topologies(), Ballot.ZERO, txnId, txn, homeKey, executeAt, deps, this));
+ node.withEpoch(executeAt.epoch, () -> Propose.propose(node,
tracker.topologies(), Ballot.ZERO, txnId, txn, route, executeAt, deps, this));
}
}
@Override
public void accept(Result success, Throwable failure)
{
+ if (failure instanceof Timeout)
Review Comment:
This is primarily a feature for the burn test to check isolation properties.
But, along with exceptions in general, a bit more thought should eventually be
given to how we do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
