adelapena commented on code in PR #2110:
URL: https://github.com/apache/cassandra/pull/2110#discussion_r1099956203
##########
src/java/org/apache/cassandra/schema/SchemaKeyspace.java:
##########
@@ -137,6 +139,11 @@ private SchemaKeyspace()
+ "kind text,"
+ "position int,"
+ "type text,"
+ + "mask_keyspace text,"
+ + "mask_name text,"
+ + "mask_argument_types frozen<list<text>>,"
+ + "mask_argument_values frozen<list<blob>>,"
+ + "mask_argument_nulls frozen<list<boolean>>," // arguments that
are null
Review Comment:
Using two tables has disadvantages in terms of complexity, space used and
performance (we duplicate reads and writes when loading and storing the
schema). However, the table is small and we don't access it very often, so the
benefit of not breaking backwards compatibility could very well outweigh the
costs, especially since we want to put this on current trunk, which is still
4.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
