bereng commented on code in PR #2110:
URL: https://github.com/apache/cassandra/pull/2110#discussion_r1101035301
##########
src/java/org/apache/cassandra/cql3/selection/Selection.java:
##########
@@ -187,7 +187,9 @@ public static Selection fromSelectors(TableMetadata table,
factories,
isJson);
- return (processesSelection(selectables) || selectables.size() !=
selectedColumns.size() || hasGroupBy)
+ boolean hasMaskedColumns =
selectedColumns.stream().anyMatch(ColumnMetadata::isMasked);
Review Comment:
I don't think readability is impacted if streams are dropped, they would
become quite simple loops. Given it's a cheap and immediate optimization I
would still avoid streams here if it were my PR but I'll defer to your
preference being the author. It's something that in multi tenancy env might be
a thing and will make a nice LHF ticket. I'll be happy to create it at least
for discussion
[CASSANDRA-18248](https://issues.apache.org/jira/browse/CASSANDRA-18248)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
