bereng commented on code in PR #2110:
URL: https://github.com/apache/cassandra/pull/2110#discussion_r1099966335
##########
src/java/org/apache/cassandra/cql3/selection/Selection.java:
##########
@@ -187,7 +187,9 @@ public static Selection fromSelectors(TableMetadata table,
factories,
isJson);
- return (processesSelection(selectables) || selectables.size() !=
selectedColumns.size() || hasGroupBy)
+ boolean hasMaskedColumns =
selectedColumns.stream().anyMatch(ColumnMetadata::isMasked);
Review Comment:
I disagree it's not in the hot path. It's not for a _specific query_ as yes,
it gets prepared only once. But it's in the hot path in terms of how many total
prepare requests we can handle. So in low prepared query scenarios _reusage_ it
will have an impact.
IOW prepare once and query 1K times we're ok. Prepare once and reuse a
handful of times we're not ok. High env traffic env where the prepared stmnts
cache rotates often we're not ok. Nodes handling multi-tenant traffic may be
handling a high number of prepares given the many different loads/apps they may
support and we're not ok.
Maybe food for another ticket? I would still avoid it here if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
