dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1153473794
##########
accord-core/src/main/java/accord/coordinate/Recover.java:
##########
@@ -172,7 +176,8 @@ public static Recover recover(Node node, Ballot ballot,
TxnId txnId, Txn txn, Fu
void start(Set<Id> nodes)
{
- node.send(nodes, to -> new BeginRecovery(to, tracker.topologies(),
txnId, txn, route, ballot), this);
+ node.send(nodes, to -> new BeginRecovery(to, tracker.topologies(),
txnId, txn, route, ballot),
Review Comment:
I did this for line length and consistency reasons. I don't see an override
in https://cassandra.apache.org/_/development/code_style.html, so our style
guide should default to 80 chars (see
https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#313)
at char 80 is `, txn, route, ballot), commandStore, this`, so I made a
personal style choice to keep the whole `BeginRecovery` on the same line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
