dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1162015464


##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -203,7 +203,7 @@ public void withEpoch(long epoch, Runnable runnable)
         else
         {
             configService.fetchTopologyForEpoch(epoch);
-            topology.awaitEpoch(epoch).addCallback(runnable);
+            topology.awaitEpoch(epoch).addCallback(runnable).begin(agent());

Review Comment:
   I changed the type returned from `awaitEpoch` to be `AsyncChain`, so need to 
"begin" it.
   
   The reason is that `AsyncResult` doesn't know what `CommandStore` to run in, 
so if you are in a `CommandStore` you need to start a new chain, so something 
has to `begin` it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to