dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1162108206
##########
accord-core/src/main/java/accord/api/MessageSink.java:
##########
@@ -27,6 +28,6 @@
public interface MessageSink
{
void send(Id to, Request request);
- void send(Id to, Request request, Callback callback);
+ void send(Id to, Request request, CommandStore commandStore, Callback
callback);
Review Comment:
after running `BurnTest` for a long time I found I actually have to use
`Executor` as some things are run in `CommandStore` only because I forced them
to with this change... stuff like our test epoch population logic shouldn't be
running in a CommandStore
> Maybe make the storage for Callback intrusive so it doesn't need to be a
separate allocation?
> It would take a little jiggering for it to be a base class since it is
currently an interface.
I don't follow this comment, what do you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
