dcapwell commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1162109403
##########
accord-core/src/main/java/accord/messages/Commit.java:
##########
@@ -162,7 +162,8 @@ public synchronized ReadNack apply(SafeCommandStore
safeStore)
case Insufficient:
SafeCommand safeCommand = safeStore.command(txnId);
Invariants.checkState(!safeCommand.current().known().isDefinitionKnown());
- if (defer == null)
+ // When isDone=true this.process() is called and all
CommandStores run apply again; so safe to create a new one
+ if (defer == null || defer.isDone)
Review Comment:
this was reverted. I fixed this bug on trunk by not relying on how many
counts were seen without taking into account the `accept` callback in the
MapReduce phase. This patch would fix things but would have a double call to
`TxnRequest.process`, the fix on trunk solves that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
