smiklosovic commented on code in PR #2253:
URL: https://github.com/apache/cassandra/pull/2253#discussion_r1158064801
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -147,9 +151,9 @@ public EncryptionOptions()
ssl_context_factory = new
ParameterizedClass("org.apache.cassandra.security.DefaultSslContextFactory",
new HashMap<>());
keystore = "conf/.keystore";
- keystore_password = "cassandra";
+ keystore_password = null;
truststore = "conf/.truststore";
- truststore_password = "cassandra";
+ truststore_password = null;
Review Comment:
@maedhroz
I do not think that having passwords defaulting to some value is a good idea
anyway. A password should be of some complex form, not "cassandra". What value
is in that, anyway? It would be quite weird to have a commented password field
and then having a certificate / keystore / truststore to have "cassandra"
password. That is just strange and I dont think that is used in practice a lot
....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
