maedhroz commented on code in PR #2253:
URL: https://github.com/apache/cassandra/pull/2253#discussion_r1158699930
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -147,9 +151,9 @@ public EncryptionOptions()
ssl_context_factory = new
ParameterizedClass("org.apache.cassandra.security.DefaultSslContextFactory",
new HashMap<>());
keystore = "conf/.keystore";
- keystore_password = "cassandra";
+ keystore_password = null;
truststore = "conf/.truststore";
- truststore_password = "cassandra";
+ truststore_password = null;
Review Comment:
Either way, I would probably add an entry in `NEWS.txt` for 5.0 in the
"Upgrading" section to explain the default change.
> I do not think that having passwords defaulting to some value is a good
idea anyway...That is just strange and I dont think that is used in practice a
lot
100% agree, and I don't know why we ever did it that way in the first place
:-|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
