smiklosovic commented on code in PR #2253:
URL: https://github.com/apache/cassandra/pull/2253#discussion_r1158275661
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -147,9 +151,9 @@ public EncryptionOptions()
ssl_context_factory = new
ParameterizedClass("org.apache.cassandra.security.DefaultSslContextFactory",
new HashMap<>());
keystore = "conf/.keystore";
- keystore_password = "cassandra";
+ keystore_password = null;
truststore = "conf/.truststore";
- truststore_password = "cassandra";
+ truststore_password = null;
Review Comment:
@maulin-vasavada what do you think about @rtib comment above? I think that
would be the most ideal solution which might be shipped in next 4.1 patch
release (probably in 4.1.2).
However, I do not think we might know the difference between "property in
yaml which is uncommented and left empty so resolved to null" and "commented
property so we will default it to `cassandra`".
Both commented property and uncommented which resolves to null are same from
the code's perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
