maulin-vasavada commented on code in PR #2253:
URL: https://github.com/apache/cassandra/pull/2253#discussion_r1158854262
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -147,9 +151,9 @@ public EncryptionOptions()
ssl_context_factory = new
ParameterizedClass("org.apache.cassandra.security.DefaultSslContextFactory",
new HashMap<>());
keystore = "conf/.keystore";
- keystore_password = "cassandra";
+ keystore_password = null;
truststore = "conf/.truststore";
- truststore_password = "cassandra";
+ truststore_password = null;
Review Comment:
If we keep the default value in the EncryptionOptions then it becomes
difficult to have tests working for PEM use-cases for the unencrypted key.
Hence I would like to keep the null assignment in the code with these changes.
If that bumps this upto go in 5.x I am fine with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
