Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1153247707
##########
src/java/org/apache/cassandra/gms/FailureDetector.java:
##########
@@ -62,14 +65,13 @@ public class FailureDetector implements IFailureDetector,
FailureDetectorMBean
private static long getMaxLocalPause()
{
- if (System.getProperty("cassandra.max_local_pause_in_ms") != null)
- {
- long pause =
Long.parseLong(System.getProperty("cassandra.max_local_pause_in_ms"));
- logger.warn("Overriding max local pause time to {}ms", pause);
- return pause * 1000000L;
- }
- else
- return DEFAULT_MAX_PAUSE;
+ long pause = MAX_LOCAL_PAUSE_IN_MS.getLong();
Review Comment:
Fixed.
##########
src/java/org/apache/cassandra/service/CassandraDaemon.java:
##########
@@ -366,9 +371,10 @@ protected void setup()
// Clean up system.size_estimates entries left lying around from
missed keyspace drops (CASSANDRA-14905)
StorageService.instance.cleanupSizeEstimates();
- // schedule periodic dumps of table size estimates into
SystemKeyspace.SIZE_ESTIMATES_CF
- // set cassandra.size_recorder_interval to 0 to disable
- int sizeRecorderInterval =
Integer.getInteger("cassandra.size_recorder_interval", 5 * 60);
+ logger.info("Schedule periodic dumps of table size estimates into
SystemKeyspace.SIZE_ESTIMATES_CF. Set -D{}=0 to disable.",
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
