Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1153573022
##########
test/distributed/org/apache/cassandra/distributed/test/PartitionDenylistTest.java:
##########
@@ -58,9 +61,9 @@ public class PartitionDenylistTest extends TestBaseImpl
public void checkStartupWithoutTriggeringUnavailable() throws IOException,
InterruptedException, ExecutionException, TimeoutException
{
int nodeCount = 4;
- System.setProperty("cassandra.ring_delay_ms", "5000"); // down from
30s default
- System.setProperty("cassandra.consistent.rangemovement", "false");
- System.setProperty("cassandra.consistent.simultaneousmoves.allow",
"true");
+ RING_DELAY.setLong(5000);
Review Comment:
Fixed.
##########
src/java/org/apache/cassandra/utils/FBUtilities.java:
##########
@@ -458,15 +463,15 @@ public static String getReleaseVersionString()
{
Properties props = getVersionProperties();
if (props == null)
- return System.getProperty("cassandra.releaseVersion",
UNKNOWN_RELEASE_VERSION);
+ return RELEASE_VERSION.getString();
return props.getProperty("CassandraVersion");
}
public static String getGitSHA()
{
Properties props = getVersionProperties();
if (props == null)
- return System.getProperty("cassandra.gitSHA", UNKNOWN_GIT_SHA);
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
