adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1188396225
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -360,6 +361,22 @@
FLUSH_LOCAL_SCHEMA_CHANGES("cassandra.test.flush_local_schema_changes",
"true"),
TOMBSTONE_HISTOGRAM_TTL_ROUND_SECONDS("cassandra.streaminghistogram.roundseconds",
"60"),
+
+ /**
+ * This property indicates with what Cassandra major version the storage
format will be compatible with.
+ *
+ * The chosen storage compatiblity mode will determine the versions of the
written sstables, commitlogs, hints,
+ * etc. Those storage elements will use the higher minor versions of the
major version that corresponds to the
+ * Cassandra version we want to stay compatible with. For example, if we
want to stay compatible with Cassandra 4.0
+ * or 4.1, the value of this property should be 4, and that will make us
use 'nc' sstables.
Review Comment:
I forgot this when changing from int to enum:
```suggestion
* or 4.1, the value of this property should be {@code CASSANDRA_4}, and
that will make us use 'nc' sstables.
```
##########
.circleci/config_template.yml:
##########
@@ -257,6 +257,10 @@ j8_separate_jobs: &j8_separate_jobs
requires:
- start_j8_unit_tests
- j8_build
+ - j8_unit_tests-oa:
Review Comment:
All the JUnit-based test jobs have a `_repeat` companion job, such as
`j8_unit_tests_repeat`, `j8_utests_cdc_repeat`, etc. We need to add analogous
`j8_utests_oa_repeat` and `j11_utests_oa_repeat` jobs.
The script `generate.sh` should also be updated to consider those new jobs.
Please let me know if you need any help with this.
##########
.circleci/config_template.yml:
##########
@@ -257,6 +257,10 @@ j8_separate_jobs: &j8_separate_jobs
requires:
- start_j8_unit_tests
- j8_build
+ - j8_unit_tests-oa:
Review Comment:
Nit: Job names should use underscores as separators, as in
`j8_unit_tests_oa` and `j11_unit_tests_oa`.
Also, for brevity and consistency with other specialized unit tests such as
`j8_utests_compression`, `j8_utests_cdc` and `j8_utests_trie`, they should
probably be named `j8_utests_oa` and `j11_utests_oa`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
