bereng commented on code in PR #2321:
URL: https://github.com/apache/cassandra/pull/2321#discussion_r1193375059
##########
src/java/org/apache/cassandra/db/guardrails/GuardrailsMBean.java:
##########
@@ -468,6 +468,30 @@
*/
void setWriteConsistencyLevelsDisallowedCSV(String consistencyLevels);
+ /**
+ * @return The threshold to warn when encountering partitions larger than
threshold, as a string formatted as in,
+ * for example, {@code 10GiB}, {@code 20MiB}, {@code 30KiB} or {@code
40B}. A {@code null} value means disabled.
+ */
+ @Nullable
+ String getPartitionSizeWarnThreshold();
+
+ /**
+ * @return The threshold to fail when encountering partitions larger than
threshold, as a string formatted as in,
Review Comment:
I would reword all the 'fail' variant comments to highlight the operation
won't fail and it will only get logged at ERROR level. Otherwise it's confusing
imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
