adelapena commented on code in PR #2321:
URL: https://github.com/apache/cassandra/pull/2321#discussion_r1204076183
##########
src/java/org/apache/cassandra/io/sstable/format/SortedTableWriter.java:
##########
@@ -324,6 +325,19 @@ protected FileHandle openDataFile(long lengthOverride,
StatsMetadata statsMetada
return dataFile;
}
+ private void guardPartitionSize(DecoratedKey key, long rowSize)
+ {
+ if (Guardrails.partitionSize.triggersOn(rowSize, null))
+ {
+ String what = String.format("%s.%s:%s on sstable %s",
Review Comment:
Indeed `String.format` is everywhere. In this case, the message is only
built when the guardrail is actually triggered, which shouldn't be very often.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
