adelapena commented on code in PR #2321: URL: https://github.com/apache/cassandra/pull/2321#discussion_r1204072689
########## conf/cassandra.yaml: ########## @@ -1541,7 +1541,8 @@ batch_size_fail_threshold: 50KiB # Log WARN on any batches not of type LOGGED than span across more partitions than this limit unlogged_batch_across_partitions_warn_threshold: 10 -# Log a warning when compacting partitions larger than this value +# Log a warning when compacting partitions larger than this value. +# As of Cassandra 5.0, this property is deprecated in favour of partition_size_warn_threshold. Review Comment: I think that "as of" means "starting from", or versions >= 5.0, so the "and later versions" part seems redundant. Also, since it's a deprecation I think it wouldn't make sense for it to not be deprecated in later versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
