adelapena commented on code in PR #2321: URL: https://github.com/apache/cassandra/pull/2321#discussion_r1204087701
########## conf/cassandra.yaml: ########## @@ -1804,6 +1805,15 @@ drop_compact_storage_enabled: false # write_consistency_levels_warned: [] # write_consistency_levels_disallowed: [] # +# Guardrail to warn or fail when writing partitions larger than threshold. +# The guardrail is only checked when writing sstables (flush, compaction, streaming, etc.), and exceeding the fail +# threshold on that moment will only log an error message, without interrupting the operation. +# This operates on a per-sstable basis, so it won't detect a large partition if it is spread across multiple sstables. +# The warning threshold replaces the deprecated config property compaction_large_partition_warning_threshold. +# The two thresholds default to null to disable. Review Comment: > Can you add a few valid examples to see syntax/units? 100MiB, 100MB, 10KB,... Yes, I have added a couple of examples about the expected values, like the ones on the JMX methods. > My question is : should we regardless of the stream situation? Because the stream data is generated by flush and compaction or logging is enough ? I'm not sure I understand what we should do and what you mean by the stream situation. Tables streamed from other nodes would have triggered the guardrail in their node of origin. We probably don't want to scan them again in the receiver node as they arrive to avoid the performance cost of scanning them. Also, large partitions in a streamed table can be later be detected by the guardrail when those partitions are compacted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
