dcapwell commented on code in PR #46:
URL: https://github.com/apache/cassandra-accord/pull/46#discussion_r1202849777
##########
accord-core/src/main/java/accord/topology/Topology.java:
##########
@@ -236,7 +236,9 @@ private Topology forSubset(int[] newSubset, Collection<Id>
nodes)
return new Topology(epoch, shards, ranges, nodeLookup, rangeSubset,
newSubset);
}
- private <P1> int[] subsetFor(Unseekables<?, ?> select,
IndexedPredicate<P1> predicate, P1 param)
+ private enum OnUnknown { REJECT, IGNORE }
Review Comment:
here is the exception
```
java.lang.IllegalArgumentException: Range not found for
TokenKey{keyspace=demo_ks, key=-9079300900759362424}
at accord.topology.Topology.subsetFor(Topology.java:266)
at
accord.topology.Topology.visitNodeForKeysOnceOrMore(Topology.java:337)
at
accord.topology.TopologyManager.withUnsyncedEpochs(TopologyManager.java:341)
at
accord.topology.TopologyManager.withUnsyncedEpochs(TopologyManager.java:310)
at
accord.coordinate.CoordinatePreAccept.<init>(CoordinatePreAccept.java:129)
at
accord.coordinate.CoordinateTransaction.<init>(CoordinateTransaction.java:49)
at
accord.coordinate.CoordinateTransaction.coordinate(CoordinateTransaction.java:54)
at accord.local.Node.initiateCoordination(Node.java:447)
at accord.local.Node.lambda$coordinate$9(Node.java:439)
at accord.local.Node.withEpoch(Node.java:220)
at accord.local.Node.coordinate(Node.java:439)
```
So, the use case is the following
1) create a new Keyspace w/ table
2) run a txn over that new table
The `org.apache.cassandra.distributed.test.accord.NewSchemaTest` test
stresses this edge case to make sure the different epochs are supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
