dcapwell commented on code in PR #46:
URL: https://github.com/apache/cassandra-accord/pull/46#discussion_r1202870218
##########
accord-core/src/main/java/accord/primitives/Ranges.java:
##########
@@ -227,4 +234,17 @@ else if (count == result.length)
return construct(cachedRanges.completeAndDiscard(result, count));
}
+ public Map<Boolean, Ranges> partitioningBy(Predicate<? super Range> test)
Review Comment:
moved away from the `Partition` class as this actually is better the more I
looked at it... `Partition` class didn't properly handle `this.isEmpty()`, but
with a map we have a few states
1) map is empty
2) map(true)
3) map(false)
4) map(true, false)
With this change, we at least have the same signature as
`Collectors.partitioningBy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
