adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1203828124
##########
.circleci/config_template.yml:
##########
@@ -257,6 +257,10 @@ j8_separate_jobs: &j8_separate_jobs
requires:
- start_j8_unit_tests
- j8_build
+ - j8_unit_tests-oa:
Review Comment:
The naming is independent on whether the job has an approval step. For
example, `j8_utests_system_keyspace_directory` doesn't have an approval step
but it still uses the short name. I think the only reason why `j8_unit_tests`
uses that naming is because it's a shorter name, but it would be great to
rename it to `j8_utests` for consistency.
As for using underscores as separator, that's a global convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
