adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1203864543
##########
.circleci/config_template.yml:
##########
@@ -257,6 +257,10 @@ j8_separate_jobs: &j8_separate_jobs
requires:
- start_j8_unit_tests
- j8_build
+ - j8_unit_tests-oa:
Review Comment:
> I was going to look into this and then decided everything is too nosy and
cluttered already. We should use REPEATED_ANT_TEST_TARGET for all these
variations imo.
Do you want to undo the recent work on CircleCI, automatic detection of
tests, etc. to go back to the old ant task?
The reason for having multiple repeated tasks is in the pre-commit workflow
is automatically detecting new tests and running them with all possible configs
(such as with and without `oa`). Consider also that we might need to run
different types of tests (utest, jvm-dtest, upgrade) in the same push, and we
can't do that with a single `repeated_ant_test` job.
The separate workflow also uses multiple repeated tasks for symmetry and to
allow different repeated runs into the same push.
> I would leave it as it is and open a ticket to drop all specialized ant
based repeats, use the generic ant repeat instead and document it properly
I celebrate all efforts on improving CI config, but this patch should either
follow the current approach at adding new jobs or stay unmerged until those
separate improvements are done. The current jobs shouldn't be merged in their
current inconsistent state, which misses the automatic repetition of tests with
`oa`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
