adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1205276263
##########
.circleci/config_template.yml:
##########
@@ -257,6 +257,10 @@ j8_separate_jobs: &j8_separate_jobs
requires:
- start_j8_unit_tests
- j8_build
+ - j8_unit_tests-oa:
Review Comment:
The changes to CircleCI on
[`CASSANDRA-14227-trunk-deleteme`](https://github.com/bereng/cassandra/commits/CASSANDRA-14227-trunk-deleteme)
look good to me. We definitively need the flag to skip the detection of tests,
but that's something that we should probably do in a separate ticket since it's
needed in all branches.
As for testing this patch for flakies, there are 129 modified tests so it
will probably be too much for a single push. We can take the same approach that
we used for SAI, which was in a similar situation. It consists on using
`generate.sh` to produce the list of modified tests, split it into smaller
batches and produce some CircleCI pushes by manually passing the test batches
in `REPEATED_UTESTS`. I'd say 4-5 batches will do. I can do that once it's
rebased and ready for the final round of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
