adelapena commented on code in PR #2321: URL: https://github.com/apache/cassandra/pull/2321#discussion_r1205252204
########## conf/cassandra.yaml: ########## @@ -1804,6 +1805,15 @@ drop_compact_storage_enabled: false # write_consistency_levels_warned: [] # write_consistency_levels_disallowed: [] # +# Guardrail to warn or fail when writing partitions larger than threshold. +# The guardrail is only checked when writing sstables (flush, compaction, streaming, etc.), and exceeding the fail +# threshold on that moment will only log an error message, without interrupting the operation. +# This operates on a per-sstable basis, so it won't detect a large partition if it is spread across multiple sstables. +# The warning threshold replaces the deprecated config property compaction_large_partition_warning_threshold. +# The two thresholds default to null to disable. Review Comment: > These sstables that are going to stream to other nodes are generated by flush or compaction , and we may just need to use the guardrail to detecte at flush or compaction stage. I see, I have updated the comment to exclude streaming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
