belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1227354072
##########
accord-core/src/main/java/accord/local/SaveStatus.java:
##########
@@ -35,30 +35,41 @@
*/
public enum SaveStatus
{
- NotWitnessed (Status.NotWitnessed),
+ // TODO (expected): erase Uninitialised in Context once command finishes
+ // TODO (expected): we can use Uninitialised in several places to
simplify/better guarantee correct behaviour with truncation
+ Uninitialised (Status.NotDefined),
+ NotDefined (Status.NotDefined),
Review Comment:
Uninitialised just means we haven’t yet assigned it any local state - the
accessor is the first to access it. This lets us be more relaxed for some
accessors. Essentially, when asking for a Command you either need to say “give
me this command if it already exists, in which case we can be sure I’m not
resurrecting a dead command” or “here’s enough information for you to determine
that a missing command has been truncated or not”
That’s the difference between ifInitialised and get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
