belliottsmith commented on code in PR #50:
URL: https://github.com/apache/cassandra-accord/pull/50#discussion_r1227759325
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -564,6 +542,68 @@ public PartialTxn partialTxn()
{
return null;
}
+
+ private static SaveStatus initialise(SaveStatus saveStatus)
+ {
+ return saveStatus == Uninitialised ? SaveStatus.NotDefined :
saveStatus;
Review Comment:
Hmm, I thought that perhaps it could be taken by `AcceptedInvalidate` but I
don't think it can (or should, at present). I think we should maybe rejig our
state machine here in general. I think we should probably introduce a new
`PreAcceptedInvalidate` status, and then for consistency we should either
remain in `NotDefined` for both `PreAcceptedInvalidate` and
`AcceptedInvalidate` _while we don't have the definition_, or we should
transition to `PreAccepted` and `Accepted` respectively once the statuses
change. The inconsistency of behaviour is confusing right now, even if it is
correct.
##########
accord-core/src/main/java/accord/local/Command.java:
##########
@@ -564,6 +542,68 @@ public PartialTxn partialTxn()
{
return null;
}
+
+ private static SaveStatus initialise(SaveStatus saveStatus)
+ {
+ return saveStatus == Uninitialised ? SaveStatus.NotDefined :
saveStatus;
Review Comment:
Hmm, I thought that perhaps it could be taken by `AcceptedInvalidate` but I
don't think it can (or should, at present). I think we should maybe rejig our
state machine here in general. I think we should probably introduce a new
`PreAcceptedInvalidate` status, and then for consistency we should either
remain in `NotDefined` for both `PreAcceptedInvalidate` and
`AcceptedInvalidate` _while we don't have the definition_, or we should
transition to `PreAccepted` and `Accepted` respectively immediately once the
statuses change. The inconsistency of behaviour is confusing right now, even if
it is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
