belliottsmith commented on PR #50: URL: https://github.com/apache/cassandra-accord/pull/50#issuecomment-1603855796
> trying to work from the bottom up and look at the core changes after the lower level changes are reviewed... > > One big issue I have with this patch, its large and doesn't add tests for the changes... it would be great to flesh out the testing Could you list places you would like to add tests? Our unit tests for the state machine today are pretty low value IMO, compared to the burn test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
