adelapena commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1272489373
##########
src/java/org/apache/cassandra/net/Message.java:
##########
@@ -711,15 +708,12 @@ private Serializer()
public <T> void serialize(Message<T> message, DataOutputPlus out, int
version) throws IOException
{
- if (version >= VERSION_40)
- serializePost40(message, out, version);
- else
- serializePre40(message, out, version);
+ serializePost40(message, out, version);
Review Comment:
I see that the methods have already inlined, which is what impacts merge the
most. The remaining *Impl methods aren't implementations of other methods, I
think, but private utility methods. So instead of renaming with
`s/Post40/Impl/` we can just remove the `Post40`/`Impl` suffix. The methods I
mean are:
* serializeHeaderImpl
* deserializeHeaderImpl
* skipHeaderImpl
* inferMessageSizeImpl
* extractParamsSizeImpl
There shouldn't be a lot of difference between the `s/Post40/Impl/` rename
and just dropping the suffix when merging forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
