adelapena commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1272350031
##########
src/java/org/apache/cassandra/net/Message.java:
##########
@@ -711,15 +708,12 @@ private Serializer()
public <T> void serialize(Message<T> message, DataOutputPlus out, int
version) throws IOException
{
- if (version >= VERSION_40)
- serializePost40(message, out, version);
- else
- serializePre40(message, out, version);
+ serializePost40(message, out, version);
Review Comment:
If we leave it for later we will still be complicating merge. In general I
prefer simpler code over simpler merges, and since the ticket is about cleaning
up it seem that renaming the methods is in scope. I wouldn't be against doing
it later in a separate ticket though, but I think in that case we should
probably leave some TODOs about that so it's less confusing for readers. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
