michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1272320784


##########
src/java/org/apache/cassandra/db/filter/ColumnFilter.java:
##########
@@ -1004,8 +1003,6 @@ private void 
serializeRegularAndStaticColumns(RegularAndStaticColumns regularAnd
         public ColumnFilter deserialize(DataInputPlus in, int version, 
TableMetadata metadata) throws IOException
         {
             int header = in.readUnsignedByte();
-            // The meaning of isFetchAll is actually different for pre-4.0 
versions and for 4.0+ versions
-            // In 4.0+ it meant is fetch all regulars

Review Comment:
   see what i did in the last commit 
https://github.com/apache/cassandra/pull/2506/commits/8782e8dda798b3fbe09dc01d6ecfdddfe5455b4e
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to