michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1272337006
##########
src/java/org/apache/cassandra/service/pager/PagingState.java:
##########
@@ -400,9 +400,9 @@ public static RowMark create(TableMetadata metadata, Row
row, ProtocolVersion pr
}
else
{
- // We froze the serialization version to 3.0 as we need to
make this this doesn't change (that is, it has to be
- // fix for a given version of the protocol).
- mark = Clustering.serializer.serialize(row.clustering(),
MessagingService.VERSION_30, makeClusteringTypes(metadata));
+ // We froze the serialization version to 3.0 as we need to
make sure this this doesn't change
+ // It got bumped to 4.0 when 3.0 got dropped, knowing it
didn't chamge
Review Comment:
updated existing commit.
##########
src/java/org/apache/cassandra/net/ParamType.java:
##########
@@ -40,25 +39,17 @@
* will skip over any params it doesn't recognise.
*
* Please don't add boolean params here. Extend and use {@link MessageFlag}
instead.
+ *
+ * Do not re-use old, of fill gaps in the sequence of, ids. New IDs must be
higher.
Review Comment:
updated existing commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
