mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1342851973
##########
src/java/org/apache/cassandra/index/sai/IndexContext.java:
##########
@@ -354,6 +371,11 @@ public boolean isLiteral()
return TypeUtil.isLiteral(getValidator());
}
+ public boolean isVector()
+ {
+ return getValidator().isVector() &&
((VectorType<?>)getValidator()).elementType instanceof FloatType;
Review Comment:
I'm in favour of 1 for the time being. I don't think treating them as
literals makes sense at all. If we were going to index them, using an index
other than ANN, it's more likely that we would follow the collections path and
effectively tokenize them, or something new.
I'll add some validation to block this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
