adelapena commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1350176074
##########
src/java/org/apache/cassandra/index/sai/IndexContext.java:
##########
@@ -354,6 +371,11 @@ public boolean isLiteral()
return TypeUtil.isLiteral(getValidator());
}
+ public boolean isVector()
+ {
+ return getValidator().isVector() &&
((VectorType<?>)getValidator()).elementType instanceof FloatType;
Review Comment:
Yes, that makes sense. I guess that if we were to ever allow indexing
vectors as literal one might consider making it the default, so the most basic
equality indexing is the default. But ANN seems much more useful in practice,
so I guess it's better to have it as the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
