adelapena commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1349576732
##########
src/java/org/apache/cassandra/db/marshal/VectorType.java:
##########
@@ -365,6 +366,7 @@ public abstract class VectorSerializer extends
TypeSerializer<List<T>>
public abstract <V> List<V> split(V buffer, ValueAccessor<V> accessor);
public abstract <V> V serializeRaw(List<V> elements, ValueAccessor<V>
accessor);
+ public abstract float[] deserializeFloatArray(ByteBuffer input);
Review Comment:
I see, but `deserializeFloatArray ` is an instance method with access to
dimension. It produces the same output for the same input as `composeAsFloat`
unless the input is of a different dimension than the type instance it belongs
to, I think. Can this ever happen, that we call it with an input of different
size? If that's the case, it should probably be a static method. If not, then
one of the implementations seems redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
