mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1355010940
##########
src/java/org/apache/cassandra/db/marshal/VectorType.java:
##########
@@ -365,6 +366,7 @@ public abstract class VectorSerializer extends
TypeSerializer<List<T>>
public abstract <V> List<V> split(V buffer, ValueAccessor<V> accessor);
public abstract <V> V serializeRaw(List<V> elements, ValueAccessor<V>
accessor);
+ public abstract float[] deserializeFloatArray(ByteBuffer input);
Review Comment:
Having looked again, I see that the `deserializeFloatArray` is only
implemented for the `Fixed` variant of the serializer, so it can be removed in
favour of the `composeAsFloat`. The `deserializeFloatArray` was added because
it could shortcut the deserialization by using the `FloatBuffer` to get the
array. I have added a `ValueAccessor.toFloatArray` method in order to support
this optimisation for `ByteBuffer`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
